Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
W
webmagic
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
沈俊林
webmagic
Commits
ff2f588c
Commit
ff2f588c
authored
Dec 04, 2013
by
yihua.huang
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
#48 nullpointer exception
parent
ac516f9b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
2 deletions
+9
-2
HttpClientDownloader.java
...s/codecraft/webmagic/downloader/HttpClientDownloader.java
+1
-2
HttpClientDownloaderTest.java
...decraft/webmagic/downloader/HttpClientDownloaderTest.java
+8
-0
No files found.
webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java
View file @
ff2f588c
...
...
@@ -47,8 +47,7 @@ public class HttpClientDownloader implements Downloader {
* @return html
*/
public
Html
download
(
String
url
)
{
Page
page
=
download
(
new
Request
(
url
),
null
);
return
(
Html
)
page
.
getHtml
();
return
download
(
url
,
null
);
}
/**
...
...
webmagic-core/src/test/java/us/codecraft/webmagic/downloader/HttpClientDownloaderTest.java
View file @
ff2f588c
...
...
@@ -6,6 +6,7 @@ import org.junit.Test;
import
us.codecraft.webmagic.Page
;
import
us.codecraft.webmagic.Request
;
import
us.codecraft.webmagic.Site
;
import
us.codecraft.webmagic.selector.Html
;
/**
* Author: code4crafer@gmail.com
...
...
@@ -23,4 +24,11 @@ public class HttpClientDownloaderTest {
Assert
.
assertTrue
(
download
.
getHtml
().
toString
().
contains
(
"flashsword30"
));
}
@Test
public
void
testDownloader
()
{
HttpClientDownloader
httpClientDownloader
=
new
HttpClientDownloader
();
Html
html
=
httpClientDownloader
.
download
(
"http://www.oschina.net"
);
Assert
.
assertTrue
(!
html
.
getText
().
isEmpty
());
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment