Commit d61f65ce authored by yihua.huang's avatar yihua.huang

update mbean to mxbean #98

parent ad6a273b
...@@ -40,13 +40,13 @@ public class SpiderMonitor { ...@@ -40,13 +40,13 @@ public class SpiderMonitor {
private Type type = Type.Local; private Type type = Type.Local;
private List<SpiderStatusMBean> spiderStatuses = new ArrayList<SpiderStatusMBean>(); private List<SpiderStatusMXBean> spiderStatuses = new ArrayList<SpiderStatusMXBean>();
public List<SpiderStatusMBean> getSpiders() { public List<SpiderStatusMXBean> getSpiders() {
return spiderStatuses; return spiderStatuses;
} }
public SpiderStatusMBean getSpider() { public SpiderStatusMXBean getSpider() {
return spiderStatuses.get(0); return spiderStatuses.get(0);
} }
...@@ -70,7 +70,7 @@ public class SpiderMonitor { ...@@ -70,7 +70,7 @@ public class SpiderMonitor {
return this; return this;
} }
protected SpiderStatusMBean getSpiderStatusMBean(Spider spider, MonitorSpiderListener monitorSpiderListener) { protected SpiderStatusMXBean getSpiderStatusMBean(Spider spider, MonitorSpiderListener monitorSpiderListener) {
return new SpiderStatus(spider, monitorSpiderListener); return new SpiderStatus(spider, monitorSpiderListener);
} }
...@@ -182,7 +182,7 @@ public class SpiderMonitor { ...@@ -182,7 +182,7 @@ public class SpiderMonitor {
jmxConnServer.start(); jmxConnServer.start();
} }
for (SpiderStatusMBean spiderStatus : spiderStatuses) { for (SpiderStatusMXBean spiderStatus : spiderStatuses) {
objName = new ObjectName(jmxServerName + ":name=" + spiderStatus.getName()); objName = new ObjectName(jmxServerName + ":name=" + spiderStatus.getName());
localServer.registerMBean(spiderStatus, objName); localServer.registerMBean(spiderStatus, objName);
} }
...@@ -199,6 +199,7 @@ public class SpiderMonitor { ...@@ -199,6 +199,7 @@ public class SpiderMonitor {
SpiderMonitor spiderMonitor = new SpiderMonitor(); SpiderMonitor spiderMonitor = new SpiderMonitor();
spiderMonitor.register(oschinaSpider, githubSpider); spiderMonitor.register(oschinaSpider, githubSpider);
//
spiderMonitor.jmxStart(); spiderMonitor.jmxStart();
oschinaSpider.start(); oschinaSpider.start();
githubSpider.start(); githubSpider.start();
......
...@@ -10,7 +10,7 @@ import java.util.List; ...@@ -10,7 +10,7 @@ import java.util.List;
* @author code4crafer@gmail.com * @author code4crafer@gmail.com
* @since 0.5.0 * @since 0.5.0
*/ */
public class SpiderStatus implements SpiderStatusMBean { public class SpiderStatus implements SpiderStatusMXBean {
protected final Spider spider; protected final Spider spider;
......
...@@ -6,7 +6,7 @@ import java.util.List; ...@@ -6,7 +6,7 @@ import java.util.List;
* @author code4crafer@gmail.com * @author code4crafer@gmail.com
* @since 0.5.0 * @since 0.5.0
*/ */
public interface SpiderStatusMBean { public interface SpiderStatusMXBean {
public String getName(); public String getName();
......
...@@ -5,7 +5,7 @@ import us.codecraft.webmagic.Spider; ...@@ -5,7 +5,7 @@ import us.codecraft.webmagic.Spider;
/** /**
* @author code4crafer@gmail.com * @author code4crafer@gmail.com
*/ */
public class CustomSpiderStatus extends SpiderStatus implements CustomSpiderStatusMBean { public class CustomSpiderStatus extends SpiderStatus implements CustomSpiderStatusMXBean {
public CustomSpiderStatus(Spider spider, SpiderMonitor.MonitorSpiderListener monitorSpiderListener) { public CustomSpiderStatus(Spider spider, SpiderMonitor.MonitorSpiderListener monitorSpiderListener) {
super(spider, monitorSpiderListener); super(spider, monitorSpiderListener);
......
...@@ -3,7 +3,7 @@ package us.codecraft.webmagic.monitor; ...@@ -3,7 +3,7 @@ package us.codecraft.webmagic.monitor;
/** /**
* @author code4crafer@gmail.com * @author code4crafer@gmail.com
*/ */
public interface CustomSpiderStatusMBean extends SpiderStatusMBean { public interface CustomSpiderStatusMXBean extends SpiderStatusMXBean {
public String getSchedulerName(); public String getSchedulerName();
......
...@@ -15,7 +15,7 @@ public class SpiderMonitorTest { ...@@ -15,7 +15,7 @@ public class SpiderMonitorTest {
public void testInherit() throws Exception { public void testInherit() throws Exception {
SpiderMonitor spiderMonitor = new SpiderMonitor(){ SpiderMonitor spiderMonitor = new SpiderMonitor(){
@Override @Override
protected SpiderStatusMBean getSpiderStatusMBean(Spider spider, MonitorSpiderListener monitorSpiderListener) { protected SpiderStatusMXBean getSpiderStatusMBean(Spider spider, MonitorSpiderListener monitorSpiderListener) {
return new CustomSpiderStatus(spider, monitorSpiderListener); return new CustomSpiderStatus(spider, monitorSpiderListener);
} }
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment